fixed sonar bugs

This commit is contained in:
jomu
2015-02-21 13:23:03 +00:00
parent 61938a6081
commit 3444384013
2 changed files with 18 additions and 14 deletions

View File

@ -1,7 +1,6 @@
package de.muehlencord.shared.sharepoint.api; package de.muehlencord.shared.sharepoint.api;
import java.text.SimpleDateFormat; import java.text.SimpleDateFormat;
import java.time.format.DateTimeFormatter;
import java.util.Date; import java.util.Date;
/** /**
@ -18,7 +17,13 @@ public class SPHelper {
if (d == null) { if (d == null) {
return ""; return "";
} }
return dateOnlyFormat.format(d);
String result;
synchronized (dateOnlyFormat) {
result = dateOnlyFormat.format(d);
}
return result;
} }
/* -- Format for DateTime Field -- */ /* -- Format for DateTime Field -- */
@ -26,8 +31,12 @@ public class SPHelper {
if (d == null) { if (d == null) {
return ""; return "";
} }
String result;
return dateTimeFormat.format(d);
synchronized (dateTimeFormat) {
result = dateTimeFormat.format(d);
}
return result;
} }
} }

View File

@ -1,7 +1,3 @@
/*
* To change this template, choose Tools | Templates
* and open the template in the editor.
*/
package de.muehlencord.shared.util.file; package de.muehlencord.shared.util.file;
import static de.muehlencord.shared.util.StringUtil.getStackTraceString; import static de.muehlencord.shared.util.StringUtil.getStackTraceString;
@ -20,7 +16,6 @@ import java.text.Format;
import static java.util.Arrays.asList; import static java.util.Arrays.asList;
import java.util.LinkedList; import java.util.LinkedList;
import java.util.List; import java.util.List;
import java.util.logging.Level;
import org.apache.log4j.Logger; import org.apache.log4j.Logger;
import static org.apache.log4j.Logger.getLogger; import static org.apache.log4j.Logger.getLogger;
@ -170,17 +165,17 @@ public abstract class FileUtil {
throw new IOException("Cannot get MD5 MessageDigest instance"); throw new IOException("Cannot get MD5 MessageDigest instance");
} }
try (InputStream is = Files.newInputStream(Paths.get(fileName))) { try (InputStream is = Files.newInputStream(Paths.get(fileName));
DigestInputStream dis = new DigestInputStream(is, md); DigestInputStream dis = new DigestInputStream(is, md)) {
int nread;
byte[] buffer = new byte[4096]; byte[] buffer = new byte[4096];
while ((nread = dis.read(buffer)) != -1) { while ((dis.read(buffer)) != -1) {
md.update(buffer); md.update(buffer);
} }
} }
byte[] digest = md.digest(); byte[] digest = md.digest();
//convert the byte to hex format method 1 //convert the byte to hex format method 1
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
for (int i = 0; i < digest.length; i++) { for (int i = 0; i < digest.length; i++) {
sb.append(Integer.toString((digest[i] & 0xff) + 0x100, 16).substring(1)); sb.append(Integer.toString((digest[i] & 0xff) + 0x100, 16).substring(1));