fixed sonar bugs

This commit is contained in:
jomu
2015-02-21 15:49:40 +00:00
parent b20d4ffd7a
commit 6a8de77311
2 changed files with 4 additions and 6 deletions

View File

@ -42,7 +42,7 @@ public class AuthenticationFilter implements Filter {
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
if ((loginPage == null) || (errorPage == null)) {
returnError(request, response, "AuthenticationFilter not properly configured! Contact Administrator.");
returnError(response, "AuthenticationFilter not properly configured! Contact Administrator.");
}
User currentUser = null;
@ -51,7 +51,7 @@ public class AuthenticationFilter implements Filter {
if (session != null) {
if (session.getAttribute(USER) != null) {
currentUser = (User) session.getAttribute(USER);
LOGGER.debug ("found "+currentUser);
LOGGER.debug("found " + currentUser);
} else {
LOGGER.debug("No active session found - going to force login");
filterConfig.getServletContext().getRequestDispatcher(loginPage).forward(request, response);
@ -74,10 +74,8 @@ public class AuthenticationFilter implements Filter {
this.filterConfig = null;
}
private void returnError(ServletRequest request, ServletResponse response, String errorMsg) {
private void returnError(ServletResponse response, String errorMsg) {
response.setContentType("text/html");
try (
ServletOutputStream servletOutputStream = response.getOutputStream();
PrintStream ps = new PrintStream(servletOutputStream);