jomu/shared
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases 7 Activity

fixed sonar bugs

Browse Source
This commit is contained in:
jomu
2015-02-23 00:26:03 +00:00
parent 2bdf8a9e68
commit 6d63141828
4 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
network/src/main/java/de/muehlencord/shared/network/http/HttpLayer.java
View File

@ -10,12 +10,12 @@ import java.net.MalformedURLException;
import java.net.URL; import java.net.URL;
import java.net.URLConnection; import java.net.URLConnection;
import java.net.URLEncoder; import java.net.URLEncoder;
import java.util.HashMap;
import java.util.Iterator; import java.util.Iterator;
import java.util.LinkedList; import java.util.LinkedList;
import java.util.List; import java.util.List;
import java.util.Locale; import java.util.Locale;
import java.util.Map; import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import org.apache.log4j.Logger; import org.apache.log4j.Logger;
/** /**
@ -50,7 +50,7 @@ public class HttpLayer {
*/ */
public void post(String parameter, String message) public void post(String parameter, String message)
throws MessageNotSendException { throws MessageNotSendException {
Map<String, String[]> parameterMap = new HashMap<>(); Map<String, String[]> parameterMap = new ConcurrentHashMap<>();
String[] valueArray = {message}; String[] valueArray = {message};
parameterMap.put(parameter, valueArray); parameterMap.put(parameter, valueArray);
post(parameterMap); post(parameterMap);

9
network/src/main/java/de/muehlencord/shared/network/whois/AbstractWhoisParser.java
View File

@ -1,12 +1,7 @@
/*
* To change this template, choose Tools | Templates
* and open the template in the editor.
*/
package de.muehlencord.shared.network.whois; package de.muehlencord.shared.network.whois;
import de.muehlencord.shared.network.whois.WhoisParser;
import java.util.HashMap;
import java.util.Map; import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
/** /**
* *
@ -15,7 +10,7 @@ import java.util.Map;
public abstract class AbstractWhoisParser implements WhoisParser { public abstract class AbstractWhoisParser implements WhoisParser {
protected Map<String, String> getValueMap(String blockString) { protected Map<String, String> getValueMap(String blockString) {
Map<String, String> returnMap = new HashMap<>(); Map<String, String> returnMap = new ConcurrentHashMap<>();
String[] lines = blockString.split("\n"); String[] lines = blockString.split("\n");
for (String line : lines) { for (String line : lines) {

2
network/src/main/java/de/muehlencord/shared/network/whois/NetworkInformation.java
View File

@ -7,6 +7,8 @@ import java.io.Serializable;
* @author jomu * @author jomu
*/ */
public class NetworkInformation implements Serializable { public class NetworkInformation implements Serializable {
/** the serial version uid */
private static final long serialVersionUID = 5099628868075224118L;
// private String network; // private String network;
private String netname; private String netname;

4
sharepoint/api/src/main/java/de/muehlencord/shared/sharepoint/api/lists/SPList.java
View File

@ -19,9 +19,9 @@ import java.net.MalformedURLException;
import java.security.KeyManagementException; import java.security.KeyManagementException;
import java.security.NoSuchAlgorithmException; import java.security.NoSuchAlgorithmException;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.HashMap;
import java.util.LinkedList; import java.util.LinkedList;
import java.util.Map; import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import javax.xml.bind.JAXBException; import javax.xml.bind.JAXBException;
import javax.xml.parsers.ParserConfigurationException; import javax.xml.parsers.ParserConfigurationException;
import javax.xml.ws.BindingProvider; import javax.xml.ws.BindingProvider;
@ -198,7 +198,7 @@ public class SPList extends SPJaxbObject<List> {
java.util.List<java.util.List<String>> listItems = getListItems(listColumnNames, rowLimit); java.util.List<java.util.List<String>> listItems = getListItems(listColumnNames, rowLimit);
// convert to map from value to <ID>;#<value> // convert to map from value to <ID>;#<value>
Map<String, String> returnMap = new HashMap<>(); Map<String, String> returnMap = new ConcurrentHashMap<>();
for (java.util.List<String> row : listItems) { for (java.util.List<String> row : listItems) {
String rowId = row.get(0); String rowId = row.get(0);